Re: [PATCH 29/36] build: use git-clean

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2017-11-05 at 17:25 +0100, Luc Van Oostenryck wrote:
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@xxxxxxxxx>
> ---
>  Makefile | 12 ++----------
>  1 file changed, 2 insertions(+), 10 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index afc1efe98..f0f7a5b69 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -233,16 +233,8 @@ check: all
>  	$(Q)cd validation && ./test-suite
>  
>  
> -clean: clean-check
> -	@rm -f *.[oa] .*.d $(PROGRAMS) version.h
> -clean-check:
> +clean: FORCE
>  	@echo '     CLEAN'
> -	@find validation/ \( -name "*.c.output.expected" \
> -	                 -o -name "*.c.output.got" \
> -	                 -o -name "*.c.output.diff" \
> -	                 -o -name "*.c.error.expected" \
> -	                 -o -name "*.c.error.got" \
> -	                 -o -name "*.c.error.diff" \
> -	                 \) -exec rm {} \;
> +	@git clean -q -d -x -e .sparse.mk -e '*.[ch]'
>  
>  .PHONY: FORCE

This seems wrong. It's certainly possible to build sparse out of a
tarball that was generated from (e.g.) git-archive. In fact that's
generally how fedora (and I imagine Debian) build packages.

This would break the ability to do "make clean" in that setup.
-- 
Jeff Layton <jlayton@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Newbies FAQ]     [LKML]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Trinity Fuzzer Tool]

  Powered by Linux