On Thu, Aug 17, 2017 at 7:16 AM, Luc Van Oostenryck <luc.vanoostenryck@xxxxxxxxx> wrote: > >> diff -ruN linux-checker/rc5/drivers/block/drbd/drbd_actlog.sp linux-checker/ssa/drivers/block/drbd/drbd_actlog.sp >> --- linux-checker/rc5/drivers/block/drbd/drbd_actlog.sp 2017-08-17 >> +++ linux-checker/ssa/drivers/block/drbd/drbd_actlog.sp 2017-08-17 >> @@ -26,3 +26,4 @@ >> drivers/block/drbd/drbd_int.h:1773:14: error: incompatible types in comparison expression (different address spaces) >> drivers/block/drbd/drbd_actlog.c:469:44: error: incompatible types in comparison expression (different address spaces) >> drivers/block/drbd/drbd_actlog.c:173:16: warning: context imbalance in '_drbd_md_sync_page_io' - different lock contexts for basic block >> +drivers/block/drbd/drbd_actlog.c:1244:24: warning: context imbalance in 'drbd_rs_del_all' - different lock contexts for basic block > > This one is different, it's part of the 8 or so new 'bad context' I was talking about. > I'll investigate about. I just took a quick look at this one. It's interesting. The IR seems correct, the locking is correct too. The problem seems that the 'correct' presence of phi-nodes make that some BB that were merged are not anymore. Nothing is wrong, just different code. But the context checking is quite limited and see now a path where the context could differ. I practice they won't differ and with previous code the context checking saw that because this patch was unexisting due to more aggressive merge of BB. One way to see at it is this is a false warning that appears because of a lack of BB optimizations. I've a vague idea of what can be done here. I'll look at it later, this evening. -- Luc -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
