Hi Chris, On 13 August 2017 at 20:03, Christopher Li <sparse@xxxxxxxxxxx> wrote: > On Sun, Aug 13, 2017 at 8:56 AM, Dibyendu Majumdar > <mobile@xxxxxxxxxxxxxxx> wrote: >> Hi Chris & Luc, >> >> >> I am merging and testing this in my repository. I notice that after >> applying the changes related to killing of BBs - there is a >> significant slow down in Sparse. >> >> Before the merge: >> >> real: 4.3 minutes >> user: 4.1 minutes >> >> After the merge: >> >> real: 18.9 minutes >> user: 18.7 minutes >> >> I just noticed this and these are my initial tests. But I thought it Just reminding that these times are in seconds not minutes! > > I have done some testing on the rc5 vs rc4 in the kernel compile test. > > ========rc5======= > 1145.45user 514.38system 2:36.93elapsed 1057%CPU (0avgtext+0avgdata > 235540maxresident)k > 0inputs+12736outputs (0major+127283813minor)pagefaults 0swaps > ================= > ========rc4======= > 1125.58user 523.66system 2:38.09elapsed 1043%CPU (0avgtext+0avgdata > 235604maxresident)k > 0inputs+12744outputs (0major+126738411minor)pagefaults 0swaps > ================= > > I don't see the big different there. The second one shows a bit slower > is likely due to I haven't warm up my machine to run the first round. > > It is likely that your test C file has a much bigger function than the > average kernel function file. > > In for your case, even revert does not help you much right? > Because you want the result IR has more correct SSA. > I have to disable simplifications anyway to get correct IR in some cases. With the single store shortcut test that sets bitfield succeeds even when simplifications are on - but even so, I cannot turn simplifications on in practice because of other failures. It is okay by me if you want to leave the change in - I have it so I can switch it on / off in my project. Regards Dibyendu -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html