On Mon, Jul 31, 2017 at 12:21 PM, Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx> wrote: > > > On 31/07/17 16:51, Christopher Li wrote: > I thought of it more as a non-override-able list of cflags, which > are required for 'correct'/'desired' behaviour. The CFLAGS are > supposed to be user settable from the command line. So, for example, > if you wanted to compile c2xml and override the CFLAGS, then you must > know to add the output of '$(PKG_CONFIG) --cflags libxml-2.0' manually. I think CFLAGS are used by makefile implicate rules. So it has pre-existing usage pattern there. Setting CFLAGS on command line is most likely not going to work with most open source project out there, unless you give a very detai and long CFLAGS. > > I'm OK with any of the three too, but I actually think the last > patch is the best. ;-) In that case, will the simplest one line change one a better middle ground then? Obvious there is only one file need to add flags here. Just keep it simple. If more complicate flags setting required later for self checking, we can always introduce the CHECK_CFFLAGS later. Just asking. Chris -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
