On Sun, Jul 30, 2017 at 7:27 PM, Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx> wrote: > > Introduce a $(CHECKER_FLAGS) variable to allow adding flags, using > target specific variable assignments, to specific $(CHECKER) command > invocations. In particular, in a new pre-process.cs target, include > '-Wno-vla' in the flags while checking pre-process.c. > > Signed-off-by: Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx> Thanks, I want to apply it. But I have some very minor feed backs. > +pre-process.sc: CHECKER_FLAGS += -Wno-vla > + You actually don't need to introduce CHECKER_FLAGS. You can just do: pre-process.sc: CFLAGS += -Wno-vla The target specific CFLAGS will only impact pre-process.sc. I would use CHECKER_FLAGS is for some thing impact all the checker target. > > %.sc: %.c sparse > - $(QUIET_CHECK) $(CHECKER) -c $(ALL_CFLAGS) $< > + $(QUIET_CHECK) $(CHECKER) $(CHECKER_FLAGS) -c $(ALL_CFLAGS) $< If you use target specific CFLAGS, there is no need to use CHECKER_FLAGS. Chris -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
