Re: [PATCH] dissect: use built_in_ident() instead of MK_IDENT()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/19, Luc Van Oostenryck wrote:
>
> The motivation for this patch was to allow sparse to be
> compiled with clang which doesn't like what is done
> on VLAs in the MK_IDENT() macro.

could you spell please? I don't understand why clang can't compile this
code and I am just curious.

> But also, I can't see any justification for not using the
> real thing to create identifiers: built_in_ident().

Simply because MK_IDENT() is faster and simpler to use.

> CC: Oleg Nesterov <oleg@xxxxxxxxxx>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@xxxxxxxxx>
> ---
>  dissect.h      | 13 -------------
>  test-dissect.c |  6 +++---

iirc there should be another MK_IDENT user in dissect.c?

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Newbies FAQ]     [LKML]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Trinity Fuzzer Tool]

  Powered by Linux