On Tue, Jun 20, 2017 at 9:42 AM, Gerd Hoffmann <kraxel@xxxxxxxxxx> wrote: >> Yep that's cargo-culted, but from a quick grep only msm and qxl >> headers do this (the other __user annotations in uapi/drm are for >> pointers, where it's correct). Adding those maintainers. > > Yep, those looks pointless indeed. > >> Also, if you use u64_to_user_ptr helper macro sparse should have >> caught this (if not we'd need to improve the macro). > > And qxl should actually use it. > > Fix attached (compile-tested only so far), does that look ok? Yup. Assuming sparse is happy: Acked-by: me. Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
