sparse triggers warnings in net/packet/af_packet.c
in upstream Linux.
This is with sparse 0.5.0 in Fedora 20.
See below for more info.
I worked around this in source, but I think it's
a good idea to fix it in sparse as well, isn't it?
----- Forwarded message from "Michael S. Tsirkin" <mst@xxxxxxxxxx> -----
Date: Mon, 24 Nov 2014 13:32:16 +0200
From: "Michael S. Tsirkin" <mst@xxxxxxxxxx>
To: linux-kernel@xxxxxxxxxxxxxxx
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, Daniel Borkmann <dborkman@xxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Atzm Watanabe
<atzm@xxxxxxxxxxxxxxxxxx>, Hannes Frederic Sowa <hannes@xxxxxxxxxxxxxxxxxxx>, Tom Herbert <therbert@xxxxxxxxxx>, netdev@xxxxxxxxxxxxxxx
Subject: [PATCH] af_packet: fix sparse warning
Message-ID: <1416828696-3989-1-git-send-email-mst@xxxxxxxxxx>
af_packet produces lots of these:
net/packet/af_packet.c:384:39: warning: incorrect type in return expression (different modifiers)
net/packet/af_packet.c:384:39: expected struct page [pure] *
net/packet/af_packet.c:384:39: got struct page *
this seems to be because sparse does not realize that _pure
refers to function, not the returned pointer.
Tweak code slightly to avoid the warning.
Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
---
net/packet/af_packet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
index d4a877e..586229a 100644
--- a/net/packet/af_packet.c
+++ b/net/packet/af_packet.c
@@ -378,7 +378,7 @@ static void unregister_prot_hook(struct sock *sk, bool sync)
__unregister_prot_hook(sk, sync);
}
-static inline __pure struct page *pgv_to_page(void *addr)
+static inline struct page * __pure pgv_to_page(void *addr)
{
if (is_vmalloc_addr(addr))
return vmalloc_to_page(addr);
--
MST
----- End forwarded message -----
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
