Re: [PATCH 06/10] don't run sparse{c,i} tests when sparse-llvm is disabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Sep 27, 2014 at 9:37 PM, Ramsay Jones
<ramsay@xxxxxxxxxxxxxxxxxxx> wrote:
> On 27/09/14 05:29, Christopher Li wrote:
>
> Unfortunately, sparcec and sparsei are the commands that are
> used by the tests (I included sparse-llvm in the list in case
> any _future_ tests used it directly), and they do exist and
> are executable. They simply will not work if sparse-llvm is
> not built.
>

I see. That make sense.

We just need a way to specify the dependency of test commands.
e.g. sparsec depends on sparse-llvm. So if sparsec does  not exist,
or sparse-llvm does  not exist, the test will be skipped.

I am thinking some thing in the test-suite like:

set_deps sparsec sparse-llvm
set_deps sparsei sparse-llvm

...
get_deps `basename cmd`
dep_cmd=$last_result

> Note that I renamed sparse{c,i} to sparse{c,i}-in. It may have been
> better to name then sparse{c,i}.sh, since they are not really templates
> to be 'processed' to create a build product. dunno.
>

I prefer specify the dependency. Another copy is not necessary.

Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Newbies FAQ]     [LKML]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Trinity Fuzzer Tool]

  Powered by Linux