On 27/09/14 05:29, Christopher Li wrote:
> On Tue, Aug 5, 2014 at 2:38 AM, Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxx> wrote:
>> +if [ ! -x "$default_path/sparse-llvm" ]; then
>> + disabled_cmds="sparsec sparsei sparse-llvm"
>> +fi
>
> I think this can be simplified as if the test command was not found,
> then that test will be disabled. It doesn't need to be sparse llvm, it
> can be other
> test program.
Unfortunately, sparcec and sparsei are the commands that are
used by the tests (I included sparse-llvm in the list in case
any _future_ tests used it directly), and they do exist and
are executable. They simply will not work if sparse-llvm is
not built.
I did think about removing the x-bit on sparse{c,i} in git,
enabling it again in the worktree if sparse-llvm was built,
but I was concerned that would not work on cygwin and it
would possibly complicate installation. ie I didn't try it
out seriously. This patch seemed the best solution to me.
[Another idea I didn't try: name the sparse{c,i} scripts
sparse{c,i}-in and rename them as part of a successful
build of sparse-llvm]
BTW, the 'validation/backend/sum.c' fails for me on cygwin
(64-bit), but I think it is actually a problem with the
llvm interpreter lli. (it works fine on my old 32-bit Linux
laptop).
ATB,
Ramsay Jones
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
