On Fre, 2010-09-03 at 02:13 -0700, Christopher Li wrote: > On Mon, Aug 23, 2010 at 7:42 AM, Bernd Petrovitsch <bernd@xxxxxxxxxx> wrote: > > Fixup and cleanup of the modifier_string() function > > > > This patch does: > > - it fixes the modifier_string() function > > - The array with the names is made "static". > > Sorry for the late reply. No problem - August is holiday time (at least hereover) and if there are more pressing issues. > Your patch does not apply to the chrisl repository. I also notice that They were against git://git.kernel.org/pub/scm/devel/sparse/sparse.git which is listed on https://sparse.wiki.kernel.org/index.php/Main_Page. But your patch doesn't apply against it. And it doesn't apply against git://git.kernel.org/pub/scm/devel/sparse/chrisl/sparse.git - which looks at the first glance identical to the above. I found http://marc.info/?l=linux-sparse&m=126634898432123 but there is no "chrisl" branch - at least not in the output of `git branch -a`. What I'm doing wrong? > if modifier > is zero, it will return buffer without initialized. Well the modifier Ooops, ACK. Grrml, not the first time in my life that I forgot that. > is not supposed > to be zero, but still. > > Another thing in the patch is that I don't want to move the modifier > bits for just the debug > function. It is expected to have more change in the modifier bits. How about > this patch? I start with your patch and end up like this. Yes, the associative array is the better solution. And the buffer overflow is also fixed. > If that works for you, please sign it off and I will check it in. It works for me. Signed-off-by: Bernd Petrovitsch <bernd@xxxxxxxxxx> Bernd -- mobile: +43 664 4416156 http://www.sysprog.at/ Linux Software Development, Consulting and Services -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
