Re: [PATCH] Fixup and cleanup of the modifier_string() function (was Re: modifier_string() inconsistency with modifiers)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 23, 2010 at 7:42 AM, Bernd Petrovitsch <bernd@xxxxxxxxxx> wrote:
> Fixup and cleanup of the modifier_string() function
>
> This patch does:
> - it fixes the modifier_string() function
> - The array with the names is made "static".


Sorry for the late reply.

Your patch does not apply to the chrisl repository. I also notice that
if modifier
is zero, it will return buffer without initialized. Well the modifier
is not supposed
to be zero, but still.

Another thing in the patch is that I don't want to move the modifier
bits for just the debug
function. It is expected to have more change in the modifier bits. How about
this patch? I start with your patch and end up like this.

If that works for you, please sign it off and I will check it in.

Thanks,

Chris

Attachment: mod-string.patch
Description: Binary data


[Index of Archives]     [Newbies FAQ]     [LKML]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Trinity Fuzzer Tool]

  Powered by Linux