On Thu, 2008-04-24 at 17:03 -0700, Linus Torvalds wrote: > Heh. That does look like somebody is shifting the wrong way, and > apparently the new warning was worth something ;) Yes, definitely. The patch is on the way to linux-wireless. Losing 24 bits of entropy in the initialization vector is not good, to put it mildly. The only other "shift" warning in the kernel for my configuration indicates dead code in drivers/serial/serial_core.c: tmp.port_high = (long) port->iobase >> HIGH_BITS_OFFSET; HIGH_BITS_OFFSET is 32 bit on 64-bit systems, and port->iobase is always int. On 32-bit systems, HIGH_BITS_OFFSET is 0 and the code would not be executed. The code predates the dawn of git. The whole thing needs some serious cleanup, but apart from that, the warning appears to be harmless. There are no more warnings mentioning "shift", and the only two warnings are useful, or which one may be a serious bug. That's a pretty good result! -- Regards, Pavel Roskin -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
