On Thu, 2008-04-24 at 14:54 -0700, Linus Torvalds wrote:
> + warning(insn->pos, "right shift by bigger than source value");
The sparse warning for shifts exceeding the target width is:
"shift too big (%d) for type %d"
And the gcc 4.3 warning is
"right shift count >= width of type"
So I would suggest a similar warning is this case. Maybe "right shift
too big (%u) for source type %s" (if the source type is readily
available) or "right shift count (%d) >= width of type (%d)"
By the way, your patch has caught something interesting in
net/mac80211/tkip.c:
iv32 = data[hdr_len + 4] +
(data[hdr_len + 5] >> 8) +
(data[hdr_len + 6] >> 16) +
(data[hdr_len + 7] >> 24);
Wow!
--
Regards,
Pavel Roskin
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
