From: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxxxxxxxx>
Date: Thu, 24 Apr 2008 14:45:43 -0700
Whether it's a sign-extending cast or not depends on the source
of the cast, not destination. The final size of the cast depends
on the destination, of course.
Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
---
In thread "[PATCH] RxRPC: Fix a regression in the RXKAD security module"
On Thu, 24 Apr 2008, Linus Torvalds wrote:
>
> Ok, that looks stupid, and should even have had a warning (shifting a u16
> right by 16 should warn about it being pointless, but doesn't, because the
> compiler quietly expands it to "int" in the meantime).
>
> Hmm. I could do something to sparse that warns about that too.
Something along the lines of this?
Almost totally untested. This first patch is just preparatory to get the
next patch working.
linearize.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/linearize.c b/linearize.c
index 45bb168..ec48dac 100644
--- a/linearize.c
+++ b/linearize.c
@@ -1097,10 +1097,10 @@ static pseudo_t linearize_postop(struct entrypoint *ep, struct expression *expr)
* case, since you can't access through it anyway without another
* cast.
*/
-static struct instruction *alloc_cast_instruction(struct symbol *ctype)
+static struct instruction *alloc_cast_instruction(struct symbol *src, struct symbol *ctype)
{
int opcode = OP_CAST;
- struct symbol *base = ctype;
+ struct symbol *base = src;
if (base->ctype.modifiers & MOD_SIGNED)
opcode = OP_SCAST;
@@ -1127,7 +1127,7 @@ static pseudo_t cast_pseudo(struct entrypoint *ep, pseudo_t src, struct symbol *
return VOID;
if (from->bit_size < 0 || to->bit_size < 0)
return VOID;
- insn = alloc_cast_instruction(to);
+ insn = alloc_cast_instruction(from, to);
result = alloc_pseudo(insn);
insn->target = result;
insn->orig_type = from;
--
1.5.5.1.92.ga5bdc
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
