On Sun, Jul 22, 2018 at 11:17 AM Jonathan Cameron <jic23@xxxxxxxxxx> wrote: > > On Sun, 22 Jul 2018 12:37:20 +0000 > Brian Masney <masneyb@xxxxxxxxxxxxx> wrote: > > > On Sat, Jul 21, 2018 at 06:37:16PM +0100, Jonathan Cameron wrote: > > > On Fri, 20 Jul 2018 11:36:35 -0600 > > > Rob Herring <robh@xxxxxxxxxx> wrote: > > > > > > > On Tue, Jul 17, 2018 at 04:41:54AM -0400, Brian Masney wrote: > > > > > This patch adds support for optionally reading the prox_diode and > > > > > prox_power settings from device tree. This was tested using a LG > > > > > Nexus 5 (hammerhead) which requires a different diode than the driver > > > > > default for the IR LED. > > > > > > > > > > Signed-off-by: Brian Masney <masneyb@xxxxxxxxxxxxx> > > > > > + - amstaos,prox_diode - must be TSL2772_DIODE0, TSL2772_DIODE1, or > > > > > + TSL2772_DIODE_BOTH. > > > > > > > > s/_/-/ > > > > > > > > > + - amstaos,prox_power - must be TSL2772_100_mA, TSL2772_50_mA, TSL2772_25_mA, > > > > > + or TSL2772_13_mA. > > > > > > > > I wonder if this should be common. Perhaps we should use the existing > > > > 'led-max-microamp' as this is setting the current for an IR LED. > > > > > > Seems reasonable, then perhaps have two controls to turn on the diodes > > > above. > > > > > > > > > > > And while called 'power' this setting is current. > > > > > > Also can we have real values? I really don't like defines if they > > > aren't absolutely necessary - particularly when there is a nice real > > > unit to be used. > > > > How about these options then? > > > > amstaos,proximity-diode-0-enabled; > > amstaos,proximity-diode-1-enabled; > > led-max-microamp = <100000>; > > Works for me. Rob? I think we're bikeshedding, but I'd prefer a single property though perhaps as a list (0, 1, or <0 1>) or mask. A list would be similar to the "led-sources" property format. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
