Hi Taniya, Thank you for the patch! Perhaps something to improve: url: https://github.com/0day-ci/linux/commits/Taniya-Das/Add-support-for-LPASS-clock-controller-for-SDM845/20180614-155144 base: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next smatch warnings: drivers/clk/qcom/lpasscc-sdm845.c:197 lpass_clocks_sdm845_probe() warn: passing zero to 'PTR_ERR' # https://github.com/0day-ci/linux/commit/035d2520712de752be68d10a37650b65b6aee154 git remote add linux-review https://github.com/0day-ci/linux git remote update linux-review git checkout 035d2520712de752be68d10a37650b65b6aee154 vim +/PTR_ERR +197 drivers/clk/qcom/lpasscc-sdm845.c 035d2520 Taniya Das 2018-06-14 179 035d2520 Taniya Das 2018-06-14 180 static int lpass_clocks_sdm845_probe(struct platform_device *pdev, 035d2520 Taniya Das 2018-06-14 181 struct device_node *np, 035d2520 Taniya Das 2018-06-14 182 const struct qcom_cc_desc *desc) 035d2520 Taniya Das 2018-06-14 183 { 035d2520 Taniya Das 2018-06-14 184 struct regmap *regmap; 035d2520 Taniya Das 2018-06-14 185 struct resource res; 035d2520 Taniya Das 2018-06-14 186 void __iomem *base; 035d2520 Taniya Das 2018-06-14 187 035d2520 Taniya Das 2018-06-14 188 if (of_address_to_resource(np, 0, &res)) 035d2520 Taniya Das 2018-06-14 189 return -ENOMEM; 035d2520 Taniya Das 2018-06-14 190 035d2520 Taniya Das 2018-06-14 191 base = devm_ioremap(&pdev->dev, res.start, resource_size(&res)); 035d2520 Taniya Das 2018-06-14 192 if (IS_ERR(base)) 035d2520 Taniya Das 2018-06-14 193 return -ENOMEM; 035d2520 Taniya Das 2018-06-14 194 035d2520 Taniya Das 2018-06-14 195 regmap = devm_regmap_init_mmio(&pdev->dev, base, desc->config); 035d2520 Taniya Das 2018-06-14 196 if (!regmap) 035d2520 Taniya Das 2018-06-14 @197 return PTR_ERR(regmap); ^^^^^^^^^^^^^^^ 035d2520 Taniya Das 2018-06-14 198 035d2520 Taniya Das 2018-06-14 199 return qcom_cc_really_probe(pdev, desc, regmap); 035d2520 Taniya Das 2018-06-14 200 } 035d2520 Taniya Das 2018-06-14 201 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-soc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
