Re: [PATCH for_v23 3/7] x86/sgx: Tweak ADD_PAGE ioctl to allow adding multiple pages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 14, 2019 at 04:31:28PM -0700, Sean Christopherson wrote:
> I don't mind taking this to v23 review, but what do you mean by robustness
> in this context?

I think I kind of got this together API-wise:

#define SGX_ENCLAVE_ADD_PAGES_MEASURE 1

struct sgx_enclave_add_pages {
	__u64 src;
	__u64 offset;
	__u64 length;
	__u64 secinfo;
};

Length can be anything as long as low 8 bits are zero. The area
defined by offset and length is measured when
SGX_ENCLAVE_ADD_PAGES_MEASURE is set to 1.

I think this is the most sane API so far and does fulfill Jethro's
concerns why he originally wanted mrmask. I think this what most
users would find the most intuitive API.

Jethro, do you think you could live with this?

/Jarkko



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux