On Tue, Oct 15, 2019 at 09:18:39AM -0700, Sean Christopherson wrote: > On Tue, Oct 15, 2019 at 01:16:35PM +0300, Jarkko Sakkinen wrote: > > On Mon, Oct 07, 2019 at 09:46:07PM -0700, Sean Christopherson wrote: > > > Use the recently added assertion framework to report errors and exit > > > instead of propagating the error back up the stack. Using assertions > > > reduces code and provides more detailed error messages, and has no > > > downsides as all errors lead to exit(1) anyways, i.e. an assertion > > > isn't blocking forward progress. > > > > > > Signed-off-by: Sean Christopherson <sean.j.christopherson@xxxxxxxxx> > > > > I'm also dropping all of this. Was too hazy with it because of rush last > > week. > > > > You shoud use EXCEPT_* macros instead of your home baked ones: > > > > https://www.kernel.org/doc/html/v4.15/dev-tools/kselftest.html > > > > I don't know what you are talking about in this commit message. > > "Recently added" tells me absolutely nothing. > > It's a fairly common way to refer to changes introduced in prior patches > of the same series. > > > All I see that you are adding your own ad hoc crap. > > Yo, same team. A simple "hey, there's already macros for this!" would > suffice. Since apologies, was over the top with this. /Jarkko
