On Tue, Oct 15, 2019 at 12:32:55AM +0300, Jarkko Sakkinen wrote:
> On Tue, Oct 08, 2019 at 09:42:37PM -0700, Sean Christopherson wrote:
> > Add a nr_pages param to the ioctl for adding pages to the enclave so
> > that userspace can batch multiple pages in a single syscall. Update the
> > offset, src and nr_pages params prior to returning to userspace so that
> > the caller has sufficient information to analyze failures and can easily
> > restart the ioctl when appropriate.
> >
> > Signed-off-by: Sean Christopherson <sean.j.christopherson@xxxxxxxxx>
>
> Please provide a more robust API. Now you decrease the robustness.
>
> E.g.
>
> struct sgx_enclave_add_page_desc {
> __u64 offset;
> __u16 mrmask;
> __u8 reserved[6];
> };
>
> struct sgx_enclave_add_page {
> __u64 src;
> __u64 secinfo;
> __u64 nr_pages;
> __u64 pages;
> };
If you want to decrease robustness, this would need to be taken as part
of v23 review. It is too big design change to managed like this. I'm
not opionated here. This is just wrong order of doing things.
/Jarkko
