Sun, Feb 09, 2025 at 10:02:41PM +0100, Benjamin Larsson kirjoitti: > Support for Airoha AN7581 SoC UART and HSUART baud rate > calculation routine. ... > drivers/tty/serial/8250/8250_port.c | 26 +++++++++ > + /* > + * Airoha SoCs have custom registers for baud rate settings > + */ > + if (port->type == PORT_AIROHA) > + airoha8250_set_baud_rate(port, baud, 0); > + if (port->type == PORT_AIROHA_HS) > + airoha8250_set_baud_rate(port, baud, 1); Why is this here? Please, make it stay in your module. ... > +config SERIAL_8250_AIROHA > + bool "Airoha UART support" Why bool? > + depends on ARCH_AIROHA && OF && SERIAL_8250 What is the purpose of the OF dependency? -- With Best Regards, Andy Shevchenko
