Hi, I seem to have missed that you commented on the patch.
On 10/02/2025 07:14, Greg KH wrote:
On Sun, Feb 09, 2025 at 10:02:39PM +0100, Benjamin Larsson wrote:
The Airoha familty of SoCs have a UART hardware that is 16550-compatible
with the exception of the baud rate settings.
This patch implements code for calculating the baud rate for the Airoha
UART and HSUART.
Signed-off-by: Benjamin Larsson <benjamin.larsson@xxxxxxxxxx>
---
Changes in v4:
- Removed COMPILE_TEST from Kconfig
No, please don't do that. >
- Removed Kconfig option to build as module
No do that, you want your code as a module so that it can work in a
system that is built as a "generic system image" that does not force
your driver to be built into the main kernel image, wasting memory if
the hardware is not present.
thanks,
greg k-h
I would argue that I follow the current flow of the code. In 8250.h we have:
CONFIG_SERIAL_8250_PNP
CONFIG_SERIAL_8250_RSA
CONFIG_SERIAL_8250_FINTEK
none of those enables COMPILE_TEST or the option to compile as a module.
Neither the Airoha code or the other code is not intended to be its own
separate module, it is to be part of the 8250-driver. The 8250-driver
can be loaded as a module with or without the Airoha baud rate code.
Implementing COMPILE_TEST when the 8250-driver does not support it seems
tricky. All the ways I could think of would result in messy code and
logic. I came to the conclusion that a smaller patch that reuses the
current logic was preferable. If that argument is not good enough then I
need some guidance how to implement something what would be accepted.
MvH
Benjamin Larsson
