RE: [PATCH v2] serial: amba-pl011: Implement nbcon console

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thanks for your comment.

> On Wed, Jan 15, 2025 at 05:27:48AM +0000, Toshiyuki Sato wrote:
> > Implement the callbacks required for an NBCON console [0] on the
> > amba-pl011 console driver.
> >
> > Referred to the NBCON implementation work for 8250 [1] and imx [2].
> >
> > The normal-priority write_thread checks for console ownership
> > each time a character is printed.
> > write_atomic holds the console ownership until the entire string
> > is printed.
> >
> > UART register operations are protected from other contexts by
> > uart_port_lock, except for a final flush(nbcon_atomic_flush_unsafe)
> > on panic.
> >
> > The patch has been verified to correctly handle the output and
> > competition of messages with different priorities and flushing
> > panic message to console after nmi panic using ARM64 QEMU and
> > a physical machine(A64FX).
> >
> > [0] https://lore.kernel.org/all/ZuRRTbapH0DCj334@xxxxxxxxxxxxxxx/
> > [1]
> https://lore.kernel.org/all/20240913140538.221708-1-john.ogness@linutronix.d
> e/T/
> > [2]
> https://lore.kernel.org/linux-arm-kernel/20240913-serial-imx-nbcon-v3-1-4c62
> 7302335b@xxxxxxxxxx/T/
> >
> > Signed-off-by: Toshiyuki Sato <fj6611ie@xxxxxxxxxxxxxxxxx>
> > ---
> > This patch removes the legacy console code.
> > Please comment if you have any concerns.
> >
> > I plan to try a stress test, referencing the work for 8250.
> >
> https://lore.kernel.org/lkml/ZsdoD6PomBRsB-ow@debarbos-thinkpadt14sgen2
> i.remote.csb/#t
> >
> > Changes in v2:
> > - Remove the module parameter used to switch between legacy and nbcon.
> > - Remove codes for legacy console.
> > - Fix build errors detected by the test robot.
> > - based on 6.13-rc7
> 
> This fails to apply to my tty-next branch, which has 38 commits on top
> of that release and at least one of them caused conflicts here.  Please
> always work on the development tree you want to submit a patch to, OR
> against linux-next, to help prevent merge issues like this.

I apologize for the inconvenience. 
I would like to resubmit the patch applicable to the tty-next branch
of the tty development repository.

Regards,

Toshiyuki Sato





[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux