On 12/4/24 23:08, Arnd Bergmann wrote:
On Wed, Dec 4, 2024, at 23:44, Guenter Roeck wrote:
On 12/4/24 14:17, Arnd Bergmann wrote:
On Wed, Dec 4, 2024, at 22:09, Guenter Roeck wrote:
I had considered this at first but didn't really want to do
it like this because we should not be registering empty ports
on platforms that don't use the setserial style override for
the port configuration.
It does of course address the warning, just not the
underlying bug.
I had a look myself, and concluded that a clean fix will likely require
substantial changes to avoid regressions. Your patch series pretty much
confirms that. This is why I came up with the hack below. Yes, it doesn't
get rid of the underlying problem, but IMO it is good enough for 6.13,
or at least not worse than 6.12, while at the same time avoiding the
warning backtrace. It seems to me that a clean fix would be 6.14 material,
and I really don't want those backtraces to clog up test logs until then.
Fair enough, let's use your patch then for 6,13,
Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
Ok, I just sent it out as real patch with your Ack applied.
Thanks,
Guenter
