On Fri, Oct 25, 2024 at 01:03:25PM +0206, John Ogness wrote: > The rx stop/start callbacks also disable/enable interrupts. This disable/enable --> toggle ? > is not acceptable for the console write callback since it must > manage all interrupt disabling/enabling. toggling ? > Move the interrupt disabling/enabling/masking into helper toggling and masking ? > functions so that the console write callback can make use of > the appropriate parts in a follow-up commit. > > This is essentially refactoring and should cause no functional > change. Please, be consistent in the commit messages on how you apply terms Rx and Tx (or TX and RX, but I think the former is more usual WRT UART). This applies to the whole series. Code wise looks fine to me Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> -- With Best Regards, Andy Shevchenko
