On Fri, Oct 25, 2024 at 01:03:22PM +0206, John Ogness wrote: > This is v3 of a series to convert the 8250 driver to an NBCON > console, providing both threaded and atomic printing > implementations. v2 of this series is here [0], which also > contains additional background information about NBCON consoles > in general in the cover letter. > > To test this version I acquired real hardware (TI AM3358 > BeagleBone Black) and tested the following modes: > > RS232 > - no flow control > - software flow control > (UPF_SOFT_FLOW, UPSTAT_AUTOXOFF) > - hardware flow control > (UPF_HARD_FLOW, UPSTAT_AUTOCTS, UPSTAT_AUTORTS) > - software emulated hardware flow control > (UPF_CONS_FLOW, UPSTAT_CTS_ENABLE) > > RS485 > - with SER_RS485_RX_DURING_TX > - without SER_RS485_RX_DURING_TX > > The tests focussed on kernel logging in various combinations of > normal, warning, and panic situations. Although not related to > the console printing code changes, the tests also included > using a getty/login session on the console. > > Note that this UART (TI16750) supports a 64-byte TX-FIFO, which > is used in all console printing modes except for the software > emulated hardware flow control. Thank you for the update. I am going to review some patches at some point, but what I want to say here is that if you have a new functions to utilise something, please also check if the rest of 8250*.c may have an advantage of. It would reduce churn in case if your series already exports APIs or provides inliners for such cases. -- With Best Regards, Andy Shevchenko
