Re: [PATCH 17/22] dt-bindings: serial: document support for SA8255p

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 28, 2024 at 01:37:16PM -0700, Nikunj Kela wrote:
> Add compatibles representing UART support on SA8255p.
> 
> Clocks and interconnects are being configured in the firmware VM
> on SA8255p platform, therefore making them optional.
> 
> CC: Praveen Talari <quic_ptalari@xxxxxxxxxxx>
> Signed-off-by: Nikunj Kela <quic_nkela@xxxxxxxxxxx>
> ---
>  .../serial/qcom,serial-geni-qcom.yaml         | 58 ++++++++++++++++---
>  1 file changed, 51 insertions(+), 7 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/serial/qcom,serial-geni-qcom.yaml b/Documentation/devicetree/bindings/serial/qcom,serial-geni-qcom.yaml
> index dd33794b3534..dcd43e1353ec 100644
> --- a/Documentation/devicetree/bindings/serial/qcom,serial-geni-qcom.yaml
> +++ b/Documentation/devicetree/bindings/serial/qcom,serial-geni-qcom.yaml
> @@ -13,11 +13,42 @@ maintainers:
>  allOf:
>    - $ref: /schemas/serial/serial.yaml#

Please move entire allOf: to the place after "required:" block.

>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - qcom,sa8255p-geni-uart
> +              - qcom,sa8255p-geni-debug-uart
> +    then:
> +      required:
> +        - power-domains
> +        - power-domain-names
> +      properties:
> +        power-domains:
> +          minItems: 2
> +          maxItems: 2
> +    else:
> +      required:
> +        - clocks
> +        - clock-names
> +      properties:
> +        power-domains:
> +          maxItems: 1
> +        interconnects:
> +          maxItems: 2
> +        interconnect-names:
> +          items:
> +            - const: qup-core
> +            - const: qup-config
> +
>  properties:
>    compatible:
>      enum:
>        - qcom,geni-uart
>        - qcom,geni-debug-uart
> +      - qcom,sa8255p-geni-uart
> +      - qcom,sa8255p-geni-debug-uart

Not compatible with the old ones? Well, it is impossible. Generic
compatible like "qcom,geni-uart" means ALL DEVICES forever will be
compatible, because otherwise it just does not make any sense.  Of
course "all devices forever will be compatible" is impossible as well,
thus DT maintainers are suggesting SoC-specific compatibles all the
time, but if developers decide that they know the future, you should
keep it, right?

>  
>    clocks:
>      maxItems: 1
> @@ -26,12 +57,10 @@ properties:
>      const: se
>  
>    interconnects:
> -    maxItems: 2
> +    description: phandles of interconnect bw provider

Constraints must stay in top-level.

Best regards,
Krzysztof





[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux