On Tue, Aug 13, 2024 at 11:30:57AM +0300, Ilpo Järvinen wrote: > On Mon, 12 Aug 2024, Andy Shevchenko wrote: > > On Mon, Aug 12, 2024 at 06:56:53PM +0200, Lech Perczak wrote: ... > > > #define SC16IS7XX_IIR_ID_MASK 0x3e /* Mask for the interrupt ID */ > > > > While at it, why not convert the MASK(s) to use GENMASK()? > > It's logically coupled change, no need to have a separate patch. ... > > > #define SC16IS7XX_LSR_BRK_ERROR_MASK 0x1E /* BI, FE, PE, OE bits */ > > > > Ditto. > > No. This is not GENMASK() but combination of other bits. This mask define > should be a combination those bit defines and the comment dropped because > it adds no value after using the bit defines directly. I agree with you on this. I'm pretty fine with either approach. > > (maybe more that are not visible in the context of this patch) -- With Best Regards, Andy Shevchenko
