On Mon, Aug 12, 2024 at 06:56:53PM +0200, Lech Perczak wrote: > Now that bit definition comments were cleaned up, convert bitmask > definitions to use BIT macro for clarity. In the Subject and here: BIT() ... > #define SC16IS7XX_IIR_ID_MASK 0x3e /* Mask for the interrupt ID */ While at it, why not convert the MASK(s) to use GENMASK()? It's logically coupled change, no need to have a separate patch. ... > #define SC16IS7XX_LSR_BRK_ERROR_MASK 0x1E /* BI, FE, PE, OE bits */ Ditto. (maybe more that are not visible in the context of this patch) -- With Best Regards, Andy Shevchenko
