Re: [PATCH v2 0/3] serial: Fix regression in omap-serial and pxa

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Doug,

On Thu, 6 Jun 2024 at 21:58, Doug Brown <doug@xxxxxxxxxxxxx> wrote:
>
> This series fixes a problem observed starting with v6.9 on the PXA168
> Chumby 8 and the OMAP3530 BeagleBoard. The UART would hang and stop
> transmitting further data.
>
> The root cause ended up being the change in commit 7bfb915a597a
> ("serial: core: only stop transmit when HW fifo is empty") that
> restricted when tx_stop() could be called. It broke omap-serial and pxa.
>
> The change was intended to fix an issue with bcm63xx-uart after commit
> d11cc8c3c4b6 ("tty: serial: use uart_port_tx_limited()"). Instead, go
> back to Jonas' original patch series that fixes the issue directly in
> the bcm63xx-uart driver [1].

Thanks for taking care of this.

 Changes since V1 [2]:
>
> - Revert the broken commit and apply Jonas' patches for bcm63xx-uart
>   instead of directly fixing the issue in the pxa driver (at the time, I
>   didn't realize omap-serial was also affected).

Note that this is technically a new V1 (or V3, depending on how you
count), since the V2 of the original patchset was what became
d11cc8c3c4b6 ("tty: serial: use uart_port_tx_limited()") and you are
reverting in 1/3.

Not that this should be cause for a resend, just wanted to mention it.

Best Regards,
Jonas




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux