On Wed, Apr 10, 2024 at 09:17:28AM +0200, Jiri Slaby wrote: > On 09. 04. 24, 16:45, Andy Shevchenko wrote: > > Instead of using container_of() explicitly, introduce a helper macro. > > This saves a lot of lines of code. ... > > +#define to_max3100_port(port) container_of(port, struct max3100_port, port) > > This is wrong. If you pass something other than "port" to to_max3100_port(), > the third arg of container_of() will explode. Then don't do that :-) > Use an inline to avoid mistakes like this. Sure, thanks for catching this. Should I send an update to prevent this from happening? -- With Best Regards, Andy Shevchenko
