On 09. 04. 24, 16:45, Andy Shevchenko wrote:
Instead of using container_of() explicitly, introduce a helper macro.
This saves a lot of lines of code.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Reviewed-by: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx>
...
@@ -110,6 +111,8 @@ struct max3100_port {
struct timer_list timer;
};
+#define to_max3100_port(port) container_of(port, struct max3100_port, port)
This is wrong. If you pass something other than "port" to
to_max3100_port(), the third arg of container_of() will explode.
Use an inline to avoid mistakes like this.
regards,
--
js
suse labs
