Re: [PATCH v1 tty] 8250: microchip: pci1xxxx: Refactor TX Burst code to use pre-existing APIs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Rengarajan S <rengarajan.s@xxxxxxxxxxxxx>, kumaravel.thiagarajan@xxxxxxxxxxxxx, tharunkumar.pasumarthi@xxxxxxxxxxxxx, gregkh@xxxxxxxxxxxxxxxxxxx, linux-serial@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, unglinuxdriver@xxxxxxxxxxxxx
Subject: Re: [PATCH v1 tty] 8250: microchip: pci1xxxx: Refactor TX Burst code to use pre-existing APIs
From: Jiri Slaby <jirislaby@xxxxxxxxxx>
Date: Fri, 23 Feb 2024 07:08:43 +0100
In-reply-to: <20240222134944.1131952-1-rengarajan.s@microchip.com>
References: <20240222134944.1131952-1-rengarajan.s@microchip.com>
User-agent: Mozilla Thunderbird

On 22. 02. 24, 14:49, Rengarajan S wrote:

Updated the TX Burst implementation by changing the circular buffer
processing with the pre-existing APIs in kernel. Also updated conditional
statements and alignment issues for better readability.


Hi,

so why are you keeping the nested double loop?

--
js
suse labs

Follow-Ups:
- Re: [PATCH v1 tty] 8250: microchip: pci1xxxx: Refactor TX Burst code to use pre-existing APIs
  - From: Rengarajan.S

References:
- [PATCH v1 tty] 8250: microchip: pci1xxxx: Refactor TX Burst code to use pre-existing APIs
  - From: Rengarajan S

Prev by Date: Re: [PATCH v1 02/14] serial: core: Add UPIO_UNSET constant for unset port type
Next by Date: Re: serial:support: Using 8250 driver With MOXA CP-132EL Device
Previous by thread: Re: [PATCH v1 tty] 8250: microchip: pci1xxxx: Refactor TX Burst code to use pre-existing APIs
Next by thread: Re: [PATCH v1 tty] 8250: microchip: pci1xxxx: Refactor TX Burst code to use pre-existing APIs
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux PPP] [Linux FS] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Linmodem] [Device Mapper] [Linux Kernel for ARM]

Powered by Linux