Hello Andy, On Thu, Feb 22, 2024 at 05:11:46PM +0200, Andy Shevchenko wrote: > On Thu, Feb 22, 2024 at 12:19:23PM +0100, Uwe Kleine-König wrote: > > Instead of silently giving up, at least tell what the problem is. > > ... > > > - return PTR_ERR(data->clk); > > + return dev_err_probe(dev, PTR_ERR(data->clk), > > + "failed to get baudclk\n"); > > Why not on a single line? We are fine with relaxed limits. At least around my change I didn't spot a line that makes use of the relaxed limits, so I sticked to the overall style. > Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
