Re: [PATCH] serial: 8250_dw: Emit an error message if getting the baudclk failed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 22, 2024 at 12:19:23PM +0100, Uwe Kleine-König wrote:
> Instead of silently giving up, at least tell what the problem is.

...

> -		return PTR_ERR(data->clk);
> +		return dev_err_probe(dev, PTR_ERR(data->clk),
> +				     "failed to get baudclk\n");

Why not on a single line? We are fine with relaxed limits.

...

Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

-- 
With Best Regards,
Andy Shevchenko






[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux