On Thu, Feb 22, 2024 at 12:19:23PM +0100, Uwe Kleine-König wrote: > Instead of silently giving up, at least tell what the problem is. ... > - return PTR_ERR(data->clk); > + return dev_err_probe(dev, PTR_ERR(data->clk), > + "failed to get baudclk\n"); Why not on a single line? We are fine with relaxed limits. ... Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> -- With Best Regards, Andy Shevchenko