On Thu, Feb 01, 2024 at 01:05:42PM +0100, Jiri Slaby wrote:
> On 01. 02. 24, 11:55, Jiri Slaby (SUSE) wrote:
> > Emil reports:
> > After updating Linux on an i.MX28 board, serial communication over
> > AUART broke. When I TX from the board and measure on the TX pin, it
> > seems like the HW fifo is not emptied before the transmission is
> > stopped.
> >
> > MXS performs weird things with stop_tx(). The driver makes it
> > conditional on uart_tx_stopped().
> >
> > So the driver needs special handling. Pass the brand new UART_TX_NOSTOP
> > to uart_port_tx_flags() and handle the stop on its own.
> >
> > Signed-off-by: Jiri Slaby (SUSE) <jirislaby@xxxxxxxxxx>
> > Reported-by: Emil Kronborg <emil.kronborg@xxxxxxxxxxxxxx>
> > Fixes: 2d141e683e9a ("tty: serial: use uart_port_tx() helper")
> > Closes: https://lore.kernel.org/all/miwgbnvy3hjpnricubg76ytpn7xoceehwahupy25bubbduu23s@om2lptpa26xw/
>
> Am I unable to send a proper patch anymore?
>
> I forgot to add mxs+arm maintainers:
> Cc: Shawn Guo <shawnguo@xxxxxxxxxx>
> Cc: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> Cc: Pengutronix Kernel Team <kernel@xxxxxxxxxxxxxx>
> Cc: Fabio Estevam <festevam@xxxxxxxxx>
> Cc: NXP Linux Team <linux-imx@xxxxxxx>
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
>
> I can resend with those fixed, if you prefer...
Nah, this is fine, I'll take this as-is, thanks!
greg k-h
