On Wed, Jan 31, 2024 at 07:28:25PM +1300, Daniel Beer wrote: > On Mon, Jan 29, 2024 at 12:07:48AM +0200, Michael Zaidman wrote: > > I pushed changes into https://github.com/MichaelZaidman/hid-ft260/tree/uart > > branch and would appreciate your review and feedback before preparing the > > cumulative patch set. > > > > I addressed the first FIXME. Please correct me if I did not get right what > > you meant. > > > > I am still doubting regarding the second FIXME. I see only three tty drivers > > are using the kfifo_avail and kfifo_len to retrieve the write room and number > > of chars in the buffer, and neither use locking. What was your concern? > > I don't see anything obviously wrong, but I'm probably not the best > person to be reviewing this -- Christina has spent the most time on it > recently, and I think the FIXME comments are hers. > Thanks, Daniel, for your feedback. I see, it's my mistake. I should have reached out to both of you. I added multiple fine-grained commits to simplify the review. Christina, can you clarify the FIXME issue and review the changes? Thanks, Michael
