Re: [PATCH v4 RESEND] hid-ft260: Add serial driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jan 20, 2024 at 08:41:28PM +0200, Michael Zaidman wrote:
> Hi Daniel and Christina,
> 
> My concern with the implemented workaround is that sending a dummy report
> every 4.8 seconds eliminates the chip's power save mode functionality.
> 
> I did more testing and figured out that the baud rates 4800 and below work
> fine with power saving mode and do not require this workaround.
> 
> So, I modified the code, making it dependent on the baud rate in this commit:
> https://github.com/MichaelZaidman/hid-ft260/commit/b5a2ad68c7cebbaaba0aa1675ae376f2895e19aa
> 
> 
> Another improvement is not to activate the wakeup workaround if power
> saving mode is not enabled in EEPROM.
> https://github.com/MichaelZaidman/hid-ft260/commit/0a41f3f3a4c664edc3bb90718807f2e62fe6d375
> 
> For UART testing, I sent files via picocom opened on ttyUSB0 (ch340 USB
> dongle device) connected to ft260 UART, receiving and displaying the
> trafic in screen manager utility.
> 
> --Michael

Hi Michael,

That sounds like a good idea to me. Are you planning to submit your
improved version from here?

I don't have any FT260 hardware with me any more, so there's
unfortunately not much I can do now to help, aside from answering
questions.

Cheers,
Daniel

-- 
Daniel Beer
Firmware Engineer at Igor Institute
daniel.beer@xxxxxxxxxxxxxxxxx or +64-27-420-8101
Offices in Seattle, San Francisco, and Vancouver BC or (206) 494-3312




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux