Hi, On Thu, 18 Jan 2024 01:26:59 +0200 Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > On Thu, Jan 18, 2024 at 12:39 AM Hugo Villeneuve <hugo@xxxxxxxxxxx> wrote: > > > > From: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx> > > > > Hello, > > this patch series brings a few clean-ups and improvements to the max310x > > driver. > > > > Some of these changes are based on suggestions for the sc16is7xx driver by > > Andy Shevchenko following this dicussion: > > discussion Will fix in V2. > > > Link: https://lore.kernel.org/all/CAHp75VebCZckUrNraYQj9k=Mrn2kbYs1Lx26f5-8rKJ3RXeh-w@xxxxxxxxxxxxxx/ > > Perhaps you may add Suggested-by to the related changes. Ok, will do for some of the patches in V2. > > The changes have been tested on a custom board using a max14830 in SPI > > mode, with an external oscillator (not crystal). Tests included a simple > > communication test with a GPS connected to UART0. > > > > They also have been tested by using i2c-stub to simulate the four ports on a > > virtual I2C max14830 device, but with obvious limitations as this cannot > > simulate all the hardware functions. > > ... > > LGTM, except this one (I have commented individually) > > serial: max310x: replace ENOTSUPP with preferred EOPNOTSUPP > > (checkpatch) > > So, for the rest > Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> Thank you for the review, Hugo Villeneuve
