On Thu, 18 Jan 2024 01:24:11 +0200 Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > On Thu, Jan 18, 2024 at 12:39 AM Hugo Villeneuve <hugo@xxxxxxxxxxx> wrote: > > > > From: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx> > > > > Fixes the following checkpatch warning: > > > > WARNING: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP > > NAK. > It's a false positive. > > > According to include/linux/errno.h, ENOTSUPP is > > "Defined for the NFSv3 protocol", so replace it with preferred EOPNOTSUPP. > > The GPIO subsystem uses this internal error code internally. User > space won't get it, so users may not see this one. Hi Andy, I will drop the patch then. What about adding a comment to prevent future fixes? - return -ENOTSUPP; + return -ENOTSUPP; /* + * ENOTSUPP is used for backward compatibility + * with GPIO subsystem. + */ Hugo Villeneuve
