Re: [PATCH v4 0/3] w1: add UART w1 bus driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/01/2024 17:02, Christoph Winklhofer via B4 Relay wrote:
> Hello!
> 
> This patch contains a driver for a 1-Wire bus over UART. The driver
> utilizes the UART interface via the Serial Device Bus to create the
> 1-Wire timing patterns.
> 
> Changes in v4:
> - rework baud-rate configuration: also check max bit-time, support higher
>   baud-rates by adding a delay to complete 1-Wire cycle.
> - dt-binding w1-uart: specify baud-rates for 1-Wire operations
> - Link to v3: https://lore.kernel.org/r/20240105-w1-uart-v3-0-8687093b2e76@xxxxxxxxx
> 

You can slow down a bit. You sent v2 too late to be applied. Then you
sent v3 and next day v4.

While I like approach to release early, release often, it does not
necessarily apply to the bindings. Bindings should be complete, which
means they should describe the hardware as fully as possible.

About the driver, you can develop it incrementally, it is a good idea,
however since ~rc6 my w1 tree is closed. It will remain closed till next
rc1 is released (merge window finished). Nothing will get applied during
that time, so if you intend to add new features, better to send v5 after
the merge window (instead v4 now, v5 tomorrow, v6 next week and then v7
after rc1).

Best regards,
Krzysztof





[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux