On Thu, Dec 21, 2023 at 10:56:39AM -0500, Hugo Villeneuve wrote: > On Wed, 20 Dec 2023 17:40:42 +0200 > Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> wrote: > > On Tue, Dec 19, 2023 at 12:18:46PM -0500, Hugo Villeneuve wrote: ... > > Yes, this seems to be the correct one to fix the problem described in > > the patch 1. I dunno why the patch 1 even exists. > > Hi, > this will indeed fix the problem described in patch 1. > > However, if I remove patch 1, and I simulate the same probe error as > described in patch 1, now we get stuck forever when trying to > remove the driver. This is something that I observed before and > that patch 1 also corrected. > > The problem is caused in sc16is7xx_remove() when calling this function > > kthread_flush_worker(&s->kworker); > > I am not sure how best to handle that without patch 1. So, it means we need to root cause this issue. Because patch 1 looks really bogus. -- With Best Regards, Andy Shevchenko
