On Wed, 20 Dec 2023 18:06:29 +0200 Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> wrote: > On Tue, Dec 19, 2023 at 12:18:44PM -0500, Hugo Villeneuve wrote: > > From: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx> > > > > Hello, > > this patch series brings a few fixes, clean-ups and improvements to the > > sc16is7xx driver. > > > > Some of the patches have been suggested by Andy Shevchenko following this > > dicussion: > > > > Link: https://lore.kernel.org/all/CAHp75VebCZckUrNraYQj9k=Mrn2kbYs1Lx26f5-8rKJ3RXeh-w@xxxxxxxxxxxxxx/ > > Thanks, good series (need a bit of additional work, though). > What I really miss is the proper split of the driver. See > 0f04a81784fe ("pinctrl: mcp23s08: Split to three parts: core, I²C, SPI") > as an example of a such. Hi Andy, thank you for the reviews. I was thinking of doing the split after this current serie, and I will look at your example as a reference. Hugo Villeneuve