On Wed, 20 Dec 2023 17:58:40 +0200 Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> wrote: > On Tue, Dec 19, 2023 at 12:19:00PM -0500, Hugo Villeneuve wrote: > > From: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx> > > > > Move/reorder some functions to remove sc16is7xx_ier_set() and > > sc16is7xx_stop_tx() prototypes declarations. > > > > No functional change. > > > > sc16is7xx_ier_set() was introduced in > > commit cc4c1d05eb10 ("sc16is7xx: Properly resume TX after stop") > > Missing period after ). Otherwise LGTM. Will add it for V2. By the way, when you say LGTM, would you suggest that I add your "Acked-by" or "Reviewed-by" tag, after having fixed what you mentioned? Hugo Villeneuve