On Thu, 7 Dec 2023, Théo Lebrun wrote: > Hello, > > On Thu Dec 7, 2023 at 2:37 AM CET, Greg Kroah-Hartman wrote: > > On Thu, Nov 30, 2023 at 03:07:14PM +0100, Théo Lebrun wrote: > > > The driver uses bit shifts and hexadecimal expressions to declare > > > constants. Replace that with the BIT(), GENMASK() & FIELD_PREP_CONST() > > > macros to clarify intent. > > > > > > Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > > > Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> > > > Signed-off-by: Théo Lebrun <theo.lebrun@xxxxxxxxxxx> > > > --- > > > include/linux/amba/serial.h | 248 +++++++++++++++++++++++--------------------- > > > 1 file changed, 127 insertions(+), 121 deletions(-) > > > > As 0-day had a problem with this patch, I've applied only patch 1 of > > this series. Can you fix it up and rebase and resend the rest again > > (while adding the collected reviewed-by that some patches in this series > > had)? > > So the issue is this: the header file gets included in > arch/arm/include/debug/pl01x.S that gets included in arch/arm/kernel/debug.S > (see #include CONFIG_DEBUG_LL_INCLUDE). > > I don't see any easy way out of this, so I guess it means the patch must be > dropped. If someone confirms that there are indeed no solution to have BIT(), > GENMASK() & FIELD_PREP_CONST() accessible from assembly, I'll send the next > version. Yeah, it seems to require UART01x_FR_TXFF and UART01x_FR_BUSY, plus UART01x_DR and UART01x_FR that are not touched by your patch. I suppose the rest might be convertable though.. -- i.
