On Thu, Nov 30, 2023 at 03:07:14PM +0100, Théo Lebrun wrote: > The driver uses bit shifts and hexadecimal expressions to declare > constants. Replace that with the BIT(), GENMASK() & FIELD_PREP_CONST() > macros to clarify intent. > > Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> > Signed-off-by: Théo Lebrun <theo.lebrun@xxxxxxxxxxx> > --- > include/linux/amba/serial.h | 248 +++++++++++++++++++++++--------------------- > 1 file changed, 127 insertions(+), 121 deletions(-) As 0-day had a problem with this patch, I've applied only patch 1 of this series. Can you fix it up and rebase and resend the rest again (while adding the collected reviewed-by that some patches in this series had)? thanks, greg k-h