Re: [PATCH] serial: 8250_omap: Set the console genpd always on if no console suspend

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Tony Lindgren <tony@xxxxxxxxxxx> writes:

> * Théo Lebrun <theo.lebrun@xxxxxxxxxxx> [231124 10:39]:
>> On Fri Nov 24, 2023 at 6:37 AM CET, Tony Lindgren wrote:
>> Checking the code confirms this behavior. Grep for the macro
>> genpd_is_active_wakeup rather than GENPD_FLAG_ACTIVE_WAKEUP. It gets
>> used twice (suspend & resume), both in the same manner:
>> 
>>    if (device_wakeup_path(dev) && genpd_is_active_wakeup(genpd))
>> 
>> This means this flag won't have any impact on runtime PM handling of
>> power-domains. By the way, other users of the flag enable it at PD
>> registration & don't touch it afterwards.
>
> Setting GENPD_FLAG_ACTIVE_WAKEUP will block deeper idle states for
> the SoC most likely.

It doesn't affect idle states.  It only affects suspend states.

As Théo pointed out, system-wide suspend will ignores runtime PM
refcounts, so IMO, using this flag is the right approach.

Kevin





[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux