Tony Lindgren <tony@xxxxxxxxxxx> writes: > * Kevin Hilman <khilman@xxxxxxxxxx> [231023 21:31]: >> Instead, what should be happening is that when `no_console_suspend` is >> set, there should be an extra pm_runtime_get() which increases the >> device usecount such that the device never runtime suspends, and thus >> the domain will not get powered off. > > We already have the runtime PM usage count kept in the driver (unless > there's a bug somewhere). The issue is that on suspend the power domain > still gets shut down. > > I suspect that some of the SoC power domains get > force shut down on suspend somewhere? If setting GENPD_FLAG_ALWAYS_ON works as this patch proposes, then a force shutdown would override that genpd flag also, so I suspect the runtime PM usage count is not correct. I quick skim of 8250_omap.c, and I don't see any pm_runtime_get() calls that are conditional on no_console_suspend, which is what I would suspect for the domain to stay on. Kevin
