Re: [PATCH 1/2] dt-bindings: serial: add Broadcom's BCM63138 High Speed UART

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Rafał Miłecki <zajec5@xxxxxxxxx>, Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>, William Zhang <william.zhang@xxxxxxxxxxxx>, Anand Gore <anand.gore@xxxxxxxxxxxx>, Kursad Oney <kursad.oney@xxxxxxxxxxxx>, Rob Herring <robh+dt@xxxxxxxxxx>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>, Conor Dooley <conor+dt@xxxxxxxxxx>
Subject: Re: [PATCH 1/2] dt-bindings: serial: add Broadcom's BCM63138 High Speed UART
From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
Date: Tue, 21 Nov 2023 23:38:44 +0100
Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Jiri Slaby <jirislaby@xxxxxxxxxx>, Andre Przywara <andre.przywara@xxxxxxx>, Alexandre TORGUE <alexandre.torgue@xxxxxx>, Neil Armstrong <neil.armstrong@xxxxxxxxxx>, linux-serial@xxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, bcm-kernel-feedback-list@xxxxxxxxxxxx, Rafał Miłecki <rafal@xxxxxxxxxx>
In-reply-to: <20231121121324.23268-1-zajec5@gmail.com>
References: <20231121121324.23268-1-zajec5@gmail.com>
User-agent: Mozilla Thunderbird

On 21/11/2023 13:13, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@xxxxxxxxxx>
> 

Thank you for your patch. There is something to discuss/improve.

> +
> +properties:
> +  compatible:
> +    const: brcm,bcm63138-hs-uart
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +required:

Missing compatible.


Best regards,
Krzysztof

Follow-Ups:
- Re: [PATCH 1/2] dt-bindings: serial: add Broadcom's BCM63138 High Speed UART
  - From: Rafał Miłecki

References:
- [PATCH 1/2] dt-bindings: serial: add Broadcom's BCM63138 High Speed UART
  - From: Rafał Miłecki

Prev by Date: Re: [PATCH v4 1/5] RISC-V: Add stubs for sbi_console_putchar/getchar()
Next by Date: Re: [PATCH v4 3/5] tty/serial: Add RISC-V SBI debug console based earlycon
Previous by thread: Re: [PATCH 1/2] dt-bindings: serial: add Broadcom's BCM63138 High Speed UART
Next by thread: Re: [PATCH 1/2] dt-bindings: serial: add Broadcom's BCM63138 High Speed UART
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux PPP] [Linux FS] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Linmodem] [Device Mapper] [Linux Kernel for ARM]