Thanks for your fast respond!
@@ -2494,6 +2494,25 @@ static int send_break(struct tty_struct *tty,
unsigned int duration)
return retval;
}
+/**
+ * tty_get_mget - get modem status
Heh, the naming is funny. It apparently comes from tiocmget. But that
comes from:
tty ioctl modem get (TIOCMGET)
tty ioctl modem set (TIOCMSET)
So you should name it like tty_get_modem() not get_mget().
I didn't like the name too, but I couldn't think of another.
The function is returning the state of serial control and status
signals.
From your suggestion for the name, however, you can not deduce that at
all.
How would it be then with the following name?
tty_tioctl_state() ?
Also those extra spaces around "-" caused some issues in the generated
output and should be removed (everywhere).
Ok, I will change this in an own commit throughout the file.
Thanks
Florian
@jirislaby: Forgot to send this message to the mailing list as well!
